switch to OrdinaryDiffEq sub-packages #71
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 60 60
Lines 2652 2652
=======================================
Hits 2633 2633
Misses 19 19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks @ranocha for tackling this! One question, do we need to update the Project.toml in the main directory as well? Or if we just keep OrdinaryDIffEq in the main installation instructions do we automatically get access to all the available solvers?
@patrickersing Just a note. If we want to use some of the implicit KenCarp integrators you have experimented with into the testing we would need to include the subpackage OridinaryDiffEqSDIRK = "2d112036-d095-4a1e-ab9a-08536f3ecdbf" as well in the test/Project.toml.
I don't see OrdinaryDiffeq.jl in https://github.com/trixi-framework/TrixiShallowWater.jl/blob/main/Project.toml
Yes - but you need to load OrdinaryDiffEq instead of the sub-packages. |
Whoops, my mistake. We kept it out of the Project.toml but we would need to adjust the (yet to completed) installation instructions in the docs PR #54 |
|
Yes, that's true. We also changed the installation instructions for Trixi.jl accordingly. You should tell people to install the two OrdinaryDiffEq.jl subpackages I used in this PR. |
See trixi-framework/Trixi.jl#2266 for the corresponding PR to Trixi.jl. This should be merged after #69.